Add CloudnetV4 support and maven depedency fix #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good - has this been tested with the latest CloudNet V4 build? |
|
I installed it on my network(which is v4 - rc5) for a few hours now, and it works fine so far. |
|
However cloudnet v4 uses adventure text, and I was not sure first, how to convert. |
|
Seems like something with the Cloudnet V4 dependency is wrong (see automated test) |
|
Looks like cloudnet 4 requires at least java 17 meanwhile advancedbans still compiles on java 1.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CloudnetV4 is at the moment of this pull request still in release candidate state. It's still possible that the API changes, however I consider it as very unlikely.