Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass metaswap timestep to update_ribasim #331

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Pass metaswap timestep to update_ribasim #331

merged 2 commits into from
Oct 25, 2024

Conversation

visr
Copy link
Member

@visr visr commented Sep 30, 2024

This seems to match the signature better.

def flux_to_ribasim(self, delt_gw: float, delt_sw: float) -> None:

@visr
Copy link
Member Author

visr commented Sep 30, 2024

This was correct since this is only called if there is no metaswap. Changed it into a comment instead.

@HendrikKok HendrikKok closed this Oct 2, 2024
@HendrikKok HendrikKok reopened this Oct 3, 2024
@HendrikKok HendrikKok self-requested a review October 3, 2024 14:34
@HendrikKok HendrikKok merged commit 2447dc9 into main Oct 25, 2024
12 of 15 checks passed
@HendrikKok HendrikKok deleted the delt_sw branch October 25, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants