getBranchVramGeneric should return an unsigned value #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngheloAlf
reviewed
Dec 25, 2023
| RabbitizerInstruction inst; | ||
| RabbitizerInstruction_init(&inst, 0x14600001, 0x80000000); // bnez $v1, . + 4 + (0x1 << 2) | ||
| RabbitizerInstruction_processUniqueId(&inst); | ||
| if (RabbitizerInstruction_getBranchVramGeneric(&inst) < 0) { |
There was a problem hiding this comment.
Since this function returns an unsigned type then this check will always be false. A bit surprising if the compiler doesn't complain about this
There was a problem hiding this comment.
I had the same thought, but the compiler didn't warn, and I thought it might be good to have some test. I'll remove it if you don't think it's useful.
There was a problem hiding this comment.
Changing the compiler to gcc makes it complain
$ make CC=gcc
# ...
: warning: comparison of unsigned expression in ‘< 0’ is always false [-Wtype-limits]
Seems like clang doesn't enable -Wtype-limits as part of -Wextra like gcc does (https://reviews.llvm.org/D142826), which is a bit unfortunate
This reverts commit 55e7bc1.
AngheloAlf
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #48 .