Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix version parser #1303

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

ci: Fix version parser #1303

wants to merge 4 commits into from

Conversation

DaveSkender
Copy link
Owner

@DaveSkender DaveSkender commented Dec 26, 2024

Problem: preview version not incrementing (suffix not considered)

done when

see #1305 for primary work (will troubleshoot there first, then put here)

  • Temporarily remove all but versioner, add temp on push trigger to troubleshoot more simply
  • Prerelease “preview” tag from gitversion.yml is recognized by GitVersion
  • Version number increments correctly to v3.0.0-preview.2

Signed-off-by: Dave Skender <[email protected]>
@DaveSkender DaveSkender self-assigned this Dec 26, 2024
@Copilot Copilot bot review requested due to automatic review settings December 26, 2024 08:37

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@DaveSkender DaveSkender requested a review from Copilot December 26, 2024 08:41
@DaveSkender DaveSkender marked this pull request as draft December 26, 2024 08:41

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

.github/workflows/deploy-package.yml:58

  • The variable 'inputs.environment' is used but not defined in the provided context. Ensure that 'inputs.environment' is defined or handled properly to avoid potential errors.
if [[ "${{ inputs.environment }}" == "nuget.org" ]]; then
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold On hold / waiting
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant