Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ENVIRONMENT=production in webhook deployment #232

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Set ENVIRONMENT=production in webhook deployment #232

merged 1 commit into from
Jan 15, 2025

Conversation

roehrich-hpe
Copy link
Contributor

No description provided.

@roehrich-hpe
Copy link
Contributor Author

This is why elcap has been reporting errors when down-reving SystemConfiguration, even though I have the annotation disabled when ENVIRONMENT=production.
Error from server: conversion webhook for dataworkflowservices.github.io/v1alpha2, Kind=SystemConfiguration returned invalid metadata: metadata.annotation: Too long: must have at most 262144 bytes

@roehrich-hpe roehrich-hpe merged commit 1317d66 into master Jan 15, 2025
2 checks passed
@roehrich-hpe roehrich-hpe deleted the prod-env-in-webhook branch January 15, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdevcich bdevcich bdevcich approved these changes

@matthew-richerson matthew-richerson matthew-richerson approved these changes

@ajfloeder ajfloeder ajfloeder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roehrich-hpe @ajfloeder @matthew-richerson @bdevcich