Add RequiredDaemons list to DirectiveBreakdown #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow a user to specify a list of required daemons to their "#DW jobdw ..." directive. The new keyword is "requires=" and it takes a list of strings: requires=copy-offload,future-thing The dwdparse library is updated to support parsing a comma-separated list of strings, with a list of RE patterns for each element allowed in the list. The DirectiveBreakdownStatus has a new field RequiredDaemons to hold the list of daemons. Signed-off-by: Dean Roehrich <[email protected]>
bdevcich
reviewed
Jun 25, 2024
| }, | ||
| { | ||
| directives: []string{ | ||
| "#DW check_requires requires=copy-offload,other-thing,copy-offload", |
There was a problem hiding this comment.
might be worth a comment to state that you can't repeat
bdevcich
approved these changes
Jun 25, 2024
matthew-richerson
approved these changes
Jun 25, 2024
Signed-off-by: Dean Roehrich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a user to specify a list of required daemons to their "#DW jobdw ..." directive. The new keyword is "requires=" and it takes a list of strings:
requires=copy-offload,future-thing
The dwdparse library is updated to support parsing a comma-separated list of strings, with a list of RE patterns for each element allowed in the list.
The DirectiveBreakdownStatus has a new field RequiredDaemons to hold the list of daemons.