Fix conversion warning for ClientMount.status.AllReady #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing was lost in the conversion, since AllReady was just a v1alpha2 rollup of the data that was in the common v1alpha1/v1alpha2 status.Mounts list. This just suppresses a warning message. make generate-go-conversions See warning. Create Convert_v1alpha2...to_v1alpha1 function in conversion.go make verify make test Signed-off-by: Dean Roehrich <[email protected]>
ajfloeder
approved these changes
Jun 17, 2024
bdevcich
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing was lost in the conversion, since AllReady was just a v1alpha2 rollup of the data that was in the common v1alpha1/v1alpha2 status.Mounts list. This just suppresses a warning message.
make generate-go-conversions
See warning.
Create Convert_v1alpha2...to_v1alpha1 function in conversion.go
make verify
make test