Remove the ComputeNodes array from SystemConfiguration #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list of compute node names is already found within the spec.StorageNodes array. By having the names in just one array, rather than two, that ought to help reduce errors. However, the main problem was this: The spec.ComputeNodes array can account for up to 75% of the size of the resource on a large cluster. This has caused problems for 'kubectl apply' (client-side-apply) when it creates the "last-applied-configuration" annotation for the resource, with the serialized version of the resource exceeding the maximum allowed size of an annotation. Signed-off-by: Dean Roehrich <[email protected]>
ajfloeder
approved these changes
Feb 2, 2024
Signed-off-by: Dean Roehrich <[email protected]>
bdevcich
approved these changes
Feb 5, 2024
… list of compute nodes that are not directly matched with any of the nodes in the StorageNodes list. Signed-off-by: Dean Roehrich <[email protected]>
ajfloeder
approved these changes
Feb 7, 2024
config/crd/bases/dataworkflowservices.github.io_systemconfigurations.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Dean Roehrich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of compute node names is already found within the spec.StorageNodes array. By having the names in just one array, rather than two, that ought to help reduce errors.
However, the main problem was this: The spec.ComputeNodes array can account for up to 75% of the size of the resource on a large cluster. This has caused problems for 'kubectl apply' (client-side-apply) when it creates the "last-applied-configuration" annotation for the resource, with the serialized version of the resource exceeding the maximum allowed size of an annotation.
Add spec.ExternalComputeNodes to contain a list of compute nodes that are not directly matched with any of the nodes in the StorageNodes list.