feat: Darkflame Cinema

CMakeLists.txt

@@ -206,6 +206,7 @@ set(INCLUDED_DIRECTORIES
 	"dGame/dInventory"
 	"dGame/dMission"
 	"dGame/dEntity"
+	"dGame/dCinema"
 	"dGame/dPropertyBehaviors"
 	"dGame/dPropertyBehaviors/ControlBehaviorMessages"
 	"dGame/dUtilities"

CMakeVariables.txt

@@ -7,9 +7,9 @@ LICENSE=AGPL-3.0
 # Set __dynamic to 1 to enable the -rdynamic flag for the linker, yielding some symbols in crashlogs.
 __dynamic=1
 # Set __ggdb to 1 to enable the -ggdb flag for the linker, including more debug info.
-# __ggdb=1
+#__ggdb=1
 # Set __include_backtrace__ to 1 to includes the backtrace library for better crashlogs.
-# __include_backtrace__=1
+#__include_backtrace__=1
 # Set __compile_backtrace__ to 1 to compile the backtrace library instead of using system libraries.
 # __compile_backtrace__=1
 # Set to the number of jobs (make -j equivalent) to compile the mariadbconn files with.

dCommon/dConfig.cpp

@@ -34,7 +34,13 @@ void dConfig::ReloadConfig() {
 }
 
 const std::string& dConfig::GetValue(std::string key) {
-	return this->m_ConfigValues[key];
+	static std::string emptyString{};
+
+	const auto& it = this->m_ConfigValues.find(key);
+
+	if (it == this->m_ConfigValues.end()) return emptyString;
+
+	return it->second;
 }
 
 void dConfig::ProcessLine(const std::string& line) {

dGame/CMakeLists.txt

@@ -56,10 +56,16 @@
 	set(DGAME_SOURCES ${DGAME_SOURCES} "dUtilities/${file}")
 endforeach()
 
+add_subdirectory(dCinema)
+
+foreach(file ${DGAME_DCINEMA_SOURCES})
+	set(DGAME_SOURCES ${DGAME_SOURCES} "dCinema/${file}")
+endforeach()
+
 foreach(file ${DSCRIPTS_SOURCES})
 	set(DGAME_SOURCES ${DGAME_SOURCES} "${PROJECT_SOURCE_DIR}/dScripts/${file}")
 endforeach()
 
 add_library(dGame STATIC ${DGAME_SOURCES})
 
 target_link_libraries(dGame dDatabase Recast Detour)

dGame/EntityManager.cpp

@@ -24,6 +24,7 @@
 #include "eGameMasterLevel.h"
 #include "eReplicaComponentType.h"
 #include "eReplicaPacketType.h"
+#include "ServerPreconditions.hpp"
 
 // Configure which zones have ghosting disabled, mostly small worlds.
 std::vector<LWOMAPID> EntityManager::m_GhostingExcludedZones = {
@@ -518,13 +519,15 @@ void EntityManager::UpdateGhosting(Player* player) {
 			ghostingDistanceMax = ghostingDistanceMin;
 		}
 
-		if (observed && distance > ghostingDistanceMax && !isOverride) {
+		auto condition = ServerPreconditions::CheckPreconditions(entity, player);
+
+		if (observed && ((distance > ghostingDistanceMax && !isOverride) || !condition)) {
 			player->GhostEntity(id);
 
 			DestructEntity(entity, player->GetSystemAddress());
 
 			entity->SetObservers(entity->GetObservers() - 1);
-		} else if (!observed && ghostingDistanceMin > distance) {
+		} else if (!observed && ghostingDistanceMin > distance && condition) {
 			// Check collectables, don't construct if it has been collected
 			uint32_t collectionId = entity->GetCollectibleID();
 
@@ -566,13 +569,15 @@ void EntityManager::CheckGhosting(Entity* entity) {
 
 		const auto distance = NiPoint3::DistanceSquared(referencePoint, entityPoint);
 
-		if (observed && distance > ghostingDistanceMax) {
+		const auto precondition = ServerPreconditions::CheckPreconditions(entity, player);
+
+		if (observed && (distance > ghostingDistanceMax || !precondition)) {
 			player->GhostEntity(id);
 
 			DestructEntity(entity, player->GetSystemAddress());
 
 			entity->SetObservers(entity->GetObservers() - 1);
-		} else if (!observed && ghostingDistanceMin > distance) {
+		} else if (!observed && (ghostingDistanceMin > distance && precondition)) {
 			player->ObserveEntity(id);
 
 			ConstructEntity(entity, player->GetSystemAddress());

dGame/Player.cpp

@@ -32,9 +32,6 @@ Player::Player(const LWOOBJID& objectID, const EntityInfo info, User* user, Enti
 	m_GhostReferencePoint = NiPoint3::ZERO;
 	m_GhostOverridePoint = NiPoint3::ZERO;
 	m_GhostOverride = false;
-	m_ObservedEntitiesLength = 256;
-	m_ObservedEntitiesUsed = 0;
-	m_ObservedEntities.resize(m_ObservedEntitiesLength);
 
 	m_Character->SetEntity(this);
 
@@ -180,41 +177,21 @@ bool Player::GetGhostOverride() const {
 }
 
 void Player::ObserveEntity(int32_t id) {
-	for (int32_t i = 0; i < m_ObservedEntitiesUsed; i++) {
-		if (m_ObservedEntities[i] == 0 || m_ObservedEntities[i] == id) {
-			m_ObservedEntities[i] = id;
-
-			return;
-		}
-	}
-
-	const auto index = m_ObservedEntitiesUsed++;
-
-	if (m_ObservedEntitiesUsed > m_ObservedEntitiesLength) {
-		m_ObservedEntities.resize(m_ObservedEntitiesLength + m_ObservedEntitiesLength);
-
-		m_ObservedEntitiesLength = m_ObservedEntitiesLength + m_ObservedEntitiesLength;
-	}
-
-	m_ObservedEntities[index] = id;
+	m_ObservedEntities.emplace(id);
 }
 
 bool Player::IsObserved(int32_t id) {
-	for (int32_t i = 0; i < m_ObservedEntitiesUsed; i++) {
-		if (m_ObservedEntities[i] == id) {
-			return true;
-		}
-	}
-
-	return false;
+	return m_ObservedEntities.find(id) != m_ObservedEntities.end();
 }
 
 void Player::GhostEntity(int32_t id) {
-	for (int32_t i = 0; i < m_ObservedEntitiesUsed; i++) {
-		if (m_ObservedEntities[i] == id) {
-			m_ObservedEntities[i] = 0;
-		}
+	const auto& iter = m_ObservedEntities.find(id);
+
+	if (iter == m_ObservedEntities.end()) {
+		return;
 	}
+
+	m_ObservedEntities.erase(iter);
 }
 
 Player* Player::GetPlayer(const SystemAddress& sysAddr) {
@@ -262,9 +239,8 @@ void Player::SetDroppedCoins(uint64_t value) {
 Player::~Player() {
 	LOG("Deleted player");
 
-	for (int32_t i = 0; i < m_ObservedEntitiesUsed; i++) {
-		const auto id = m_ObservedEntities[i];
-
+	for (const auto& id : m_ObservedEntities)
+	{
 		if (id == 0) {
 			continue;
 		}

dGame/Player.h

@@ -2,6 +2,8 @@
 
 #include "Entity.h"
 
+#include <unordered_set>
+
 /**
  * Extended Entity for player data and behavior.
  *
@@ -120,11 +122,7 @@ class Player final : public Entity
 
 	bool m_GhostOverride;
 
-	std::vector<int32_t> m_ObservedEntities;
-
-	int32_t m_ObservedEntitiesLength;
-
-	int32_t m_ObservedEntitiesUsed;
+	std::unordered_set<int32_t> m_ObservedEntities;
 
 	std::vector<LWOOBJID> m_LimboConstructions;
 

dGame/dBehaviors/AttackDelayBehavior.cpp

@@ -4,13 +4,17 @@
 #include "Game.h"
 #include "Logger.h"
 
+#include "Recorder.h"
+
 void AttackDelayBehavior::Handle(BehaviorContext* context, RakNet::BitStream* bitStream, const BehaviorBranchContext branch) {
 	uint32_t handle{};
 
 	if (!bitStream->Read(handle)) {
 		LOG("Unable to read handle from bitStream, aborting Handle! %i", bitStream->GetNumberOfUnreadBits());
 		return;
 	};
+
+	Cinema::Recording::Recorder::RegisterEffectForActor(context->originator, this->m_effectId);
 
 	for (auto i = 0u; i < this->m_numIntervals; ++i) {
 		context->RegisterSyncBehavior(handle, this, branch, this->m_delay * i, m_ignoreInterrupts);

dGame/dBehaviors/PlayEffectBehavior.cpp

@@ -3,13 +3,17 @@
 #include "BehaviorContext.h"
 #include "BehaviorBranchContext.h"
 
+#include "Recorder.h"
+
 void PlayEffectBehavior::Handle(BehaviorContext* context, RakNet::BitStream* bitStream, BehaviorBranchContext branch) {
+	const auto& target = branch.target == LWOOBJID_EMPTY ? context->originator : branch.target;
+
+	Cinema::Recording::Recorder::RegisterEffectForActor(target, this->m_effectId);
+
 	// On managed behaviors this is handled by the client
 	if (!context->unmanaged)
 		return;
 
-	const auto& target = branch.target == LWOOBJID_EMPTY ? context->originator : branch.target;
-
 	PlayFx(u"", target);
 }
 

dGame/dCinema/CMakeLists.txt

@@ -0,0 +1,5 @@
+set(DGAME_DCINEMA_SOURCES "Recorder.cpp"
+    "Prefab.cpp"
+    "Scene.cpp"
+    "Play.cpp"
+    PARENT_SCOPE)

dGame/dCinema/Play.cpp

@@ -0,0 +1,89 @@
+#include "Play.h"
+
+#include "Scene.h"
+
+#include "EntityManager.h"
+
+using namespace Cinema;
+
+void Cinema::Play::Conclude() {
+	auto* player = Game::entityManager->GetEntity(this->player);
+
+	if (player == nullptr) {
+		return;
+	}
+
+	scene->Conclude(player);
+}
+
+void Cinema::Play::SetupCheckForAudience() {
+	if (m_CheckForAudience) {
+		return;
+	}
+
+	m_CheckForAudience = true;
+
+	CheckForAudience();
+}
+
+void Cinema::Play::CheckForAudience() {
+	auto* player = Game::entityManager->GetEntity(this->player);
+
+	if (player == nullptr) {
+		CleanUp();
+
+		return;
+	}
+
+	if (scene->IsPlayerInBounds(player)) {
+		SignalBarrier("audience");
+
+		m_PlayerHasBeenInsideBounds = true;
+	}
+
+	if (!scene->IsPlayerInShowingDistance(player)) {
+		if (m_PlayerHasBeenInsideBounds) {
+			Conclude();
+		}
+
+		CleanUp();
+
+		return;
+	}
+
+	// Still don't care
+	Game::entityManager->GetZoneControlEntity()->AddCallbackTimer(1.0f, [this]() {
+		CheckForAudience();
+	});
+}
+
+void Cinema::Play::CleanUp() {
+	LOG("Cleaning up play with %d entities", entities.size());
+
+	for (const auto& entity : entities) {
+		Game::entityManager->DestroyEntity(entity);
+	}
+}
+
+void Cinema::Play::SetupBarrier(const std::string& barrier, std::function<void()> callback) {
+	// Add the callback to the barrier
+	if (m_Barriers.find(barrier) == m_Barriers.end()) {
+		m_Barriers[barrier] = std::vector<std::function<void()>>();
+	}
+
+	m_Barriers[barrier].push_back(callback);
+}
+
+void Cinema::Play::SignalBarrier(const std::string& barrier) {
+	if (m_Barriers.find(barrier) == m_Barriers.end()) {
+		return;
+	}
+
+	for (const auto& callback : m_Barriers[barrier]) {
+		callback();
+	}
+
+	m_Barriers.erase(barrier);
+}
+
+