feat: add favicon #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
DaleSeo
commented
Jul 3, 2024
Comment on lines
-148
to
+162
| grid-template-columns: minmax(306px, 1fr); | ||
| grid-template-columns: minmax(306px, 1fr); |
There was a problem hiding this comment.
여기는 그냥 자동 포멧팅이 된 부분입니다. 예전에 포멧팅을 일괄 정리했는데 왜 자꾸 포멧팅이 틀어지는 모르겠네요 ㅋㅋ
There was a problem hiding this comment.
요 부분 제가 작업하면서 띄어쓰기 된 채로 푸쉬되어서 그런 것 같습니다....😅 다시 이번 pr에서 맞춰두었습니다!
There was a problem hiding this comment.
@yolophg 아하, 그렇군요. 그나저나 요 것이 Format on save 설정을 꺼놨을 때의 단점 아닐까요? 포멧팅 해주는 것을 까먹을 수 있다 ㅎㅎㅎ
|
favicon은 빠르게 머지되면 좋을 것 같습니다. 감사합니다! |
yolophg
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
몇 주 전에 @nhistory 님께서 만들어주신 Favicon 파일이 아직도 추가가 안 되어 있길래 후다닥 추가합니다 :)
Checklist before merging