Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : add weight for hover for a span and change the a tags padding #166

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

SamTheKorean
Copy link
Contributor

@SamTheKorean SamTheKorean commented Jul 19, 2024

Checklist before merging

  • Link an issue with the pull request
  • Ensure no errors or warnings on the browser console
  • Avoid additional major pushes after approval (if necessary, request a new review)

@SamTheKorean SamTheKorean self-assigned this Jul 19, 2024
@SamTheKorean SamTheKorean requested a review from a team as a code owner July 19, 2024 06:09
@SamTheKorean SamTheKorean linked an issue Jul 19, 2024 that may be closed by this pull request
@SamTheKorean
Copy link
Contributor Author

Screen.Recording.2024-07-19.at.2.09.48.AM.mov

좌우 패딩 5px로 수정하고 hover 속성에 weight 추가했습니다!

@SamTheKorean SamTheKorean merged commit fe0ecc5 into main Jul 19, 2024
1 check passed
@SamTheKorean SamTheKorean deleted the sam/161 branch July 19, 2024 13:52
@nhistory
Copy link
Contributor

@SamTheKorean 샘님, 마우스 hover 될 때 box-shadow 가 아직 그대로 있어요 ㅜㅜ
데스크탑 뷰에서는 font-weight만 hover effect로 남아있게 수정 부탁드려요.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug fix: Header hover styling
3 participants