Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gmlwls96] Week 6 #885

Merged
merged 8 commits into from
Jan 18, 2025
Merged

[gmlwls96] Week 6 #885

merged 8 commits into from
Jan 18, 2025

Conversation

gmlwls96
Copy link
Contributor

@gmlwls96 gmlwls96 commented Jan 12, 2025

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@gmlwls96 gmlwls96 requested a review from GangBean January 12, 2025 01:57
@gmlwls96 gmlwls96 requested a review from a team as a code owner January 12, 2025 01:57
Comment on lines +14 to +18
if (height[left] < height[right]) {
left++
} else {
right--
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if ~ else 사용 방법도 있고, 조건을 조금 더 추가하여 시간 복잡도는 그대로 가져가되 반복문을 통해 투 포인터를 조정하는 방법도 있을것 같아요 :)

@@ -0,0 +1,48 @@
class Node() {
val map = mutableMapOf<Char, Node?>()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정해진 캐릭터가 26자라는걸 생각하면 map 대신 다른 자료형을 통해 제한을 줄 수 있을것 같아요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 그렇네요~! 좋은 리뷰 감사합니다ㅎㅎ

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문제 풀이가 명료하고 가독성이 더 좋은것 같아요!

Copy link
Contributor

@TonyKim9401 TonyKim9401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6주차 문제 풀이 고생 많으셨습니다.
코틀린 문법 사용으로 모든 풀이의 가독성이 너무 좋았습니다.
절반 정도의 기간 동안 고생 많으셨고 남은 8주도 파이팅입니다!

@gmlwls96 gmlwls96 merged commit 0489f69 into DaleStudy:main Jan 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants