Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GangBean] Week 6 #884

Merged
merged 2 commits into from
Jan 19, 2025
Merged

[GangBean] Week 6 #884

merged 2 commits into from
Jan 19, 2025

Conversation

GangBean
Copy link
Contributor

@GangBean GangBean commented Jan 11, 2025

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@GangBean GangBean requested a review from a team as a code owner January 11, 2025 22:54
@github-actions github-actions bot added the java label Jan 11, 2025
@GangBean GangBean requested a review from HodaeSsi January 11, 2025 22:55
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

투 포인터가 줄어들 때 마다, 전체 면적이 줄어 들 때 내부 while 문을 사용하면 시간을 좀 더 효율적으로 가져갈 수도 있을것 같아요 :)

Comment on lines +25 to +27
} else {
throw new RuntimeException(String.format("Not valid input character: %c in input %s", c, s));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예외처리 보다는 false를 바로 던지시면 되지 않을까요?
해당 문제에서 return 은 true, false 만 사용하면 되니까요 :)

Copy link
Contributor

@TonyKim9401 TonyKim9401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6주차 문제 풀이 고생 많으셨습니다.
문제들을 모두 정석적으로 풀어주셔서 이해하기 편했습니다.
다음주면 벌써 7주차 입니다!
절반 정도의 기간 동안 고생 많으셨고 남은 8주도 파이팅입니다!

@GangBean GangBean merged commit b12687f into DaleStudy:main Jan 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants