Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kayden] Week 03 Solutions #393

Merged
merged 7 commits into from
Sep 1, 2024
Merged

[kayden] Week 03 Solutions #393

merged 7 commits into from
Sep 1, 2024

Conversation

kjb512
Copy link
Contributor

@kjb512 kjb512 commented Aug 27, 2024 •
edited
Loading

답안 제출 문제

체크 리스트

  • PR을 프로젝트에 추가하고 Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@github-actions github-actions bot added the py label Aug 27, 2024
@kjb512 kjb512 changed the title [kayden] Week 02 Solutions [kayden] Week 03 Solutions Aug 27, 2024
@kjb512 kjb512 requested a review from heozeop August 27, 2024 12:58
heozeop
heozeop reviewed Aug 27, 2024
View reviewed changes
two-sum/kayden.py Outdated Show resolved Hide resolved
@DaleSeo
Copy link
Contributor

DaleSeo commented Aug 28, 2024 •
edited
Loading

묻지마 체크인가요? ㅋㅋ 이러면 체크리스트의 의미가 없을 것 같아요! 😆

Shot 2024-08-27 at 21 59 15@2x

@kjb512
Copy link
Contributor Author

kjb512 commented Aug 28, 2024

숙지했습니다로 착각했네요ㅋㅋㅋㅋㅋ😅

@DaleSeo
Copy link
Contributor

DaleSeo commented Aug 28, 2024

숙지했습니다로 착각했네요ㅋㅋㅋㅋㅋ😅

여전히 PR이 프로젝트에 추가되어 있지 않은데, 1번째 항목이 체크가 되어 있네요? 😓

Shot 2024-08-28 at 06 27 46@2x

@kjb512
Copy link
Contributor Author

kjb512 commented Aug 28, 2024

숙지했습니다로 착각했네요ㅋㅋㅋㅋㅋ😅

여전히 PR이 프로젝트에 추가되어 있지 않은데, 1번째 항목이 체크가 되어 있네요? 😓

Shot 2024-08-28 at 06 27 46@2x

다음에는 제대로 확인 하겠습니다!

bky373
bky373 approved these changes Aug 30, 2024
View reviewed changes
climbing-stairs/kayden.py
@@ -0,0 +1,12 @@
# 시간복잡도: O(N)
# 공간복잡도: O(N)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 dp 를 사용하셨군요! 공간복잡도를 O(1) 로 줄일 수도 있는데 시간 되실 때 시도해보시면 좋을 것 같습니다!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

답변 감사합니다! 다시 보니, 변수 두개로도 가능하겠군요!

@DaleSeo
Copy link
Contributor

DaleSeo commented Aug 31, 2024

@kjb512 3주차 마감이 임박했으니 PR을 Ready for review로 전환하시고 프로젝트에서 Status를 In Review로 설정 부탁드리겠습니다.

DaleSeo
DaleSeo approved these changes Aug 31, 2024
View reviewed changes
Copy link
Contributor

@DaleSeo DaleSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

product-of-array-except-self/kayden.py
@@ -0,0 +1,18 @@
# 시간복잡도: O(N)
# 공간복잡도: out 제외시 O(1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오해가 없도록 out 제외시라고 붙여주셔서 좋네요!

@kjb512 kjb512 marked this pull request as ready for review August 31, 2024 05:44
@kjb512 kjb512 requested a review from a team as a code owner August 31, 2024 05:44
@kjb512 kjb512 merged commit 208ccc7 into DaleStudy:main Sep 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heozeop heozeop heozeop left review comments

@bky373 bky373 bky373 approved these changes

@DaleSeo DaleSeo DaleSeo approved these changes

Assignees

@kjb512 kjb512

Labels
py
Projects
No open projects
리트코드 스터디 2기
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kjb512 @DaleSeo @heozeop @bky373