프로그레스 페이지 반응형 디자인 구현 및 접근성 디자인 적용 #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ui 변경 사항 리뷰 중 수정사항이 보여서 draft로 전환했습니다. |
|
변경필요한 부분 수정하고 커밋한 뒤에 다시 pr 열었습니다! |
Sunjae95
reviewed
Jan 11, 2025
src/components/Table/Table.tsx
Outdated
| /> | ||
| ); | ||
| } | ||
| const iconClass = completed ? styles.completedIcon : styles.incompleteIcon; |
There was a problem hiding this comment.
nit) 다른 부분도 모두 삼항연사자로 작성하셨는데 이 부분만 따로 변수로 지정한 이유가 궁금합니다!
There was a problem hiding this comment.
다른 부분과 일관되게 바꿔보겠습니다!
There was a problem hiding this comment.
이 부분 수정해주신다고 하셨는데 수정됐을까요~?
There was a problem hiding this comment.
피드백을 지금 완전히 이해했습니다!
function getTaskIcon(completed: boolean) {
return (
<img
src={`/ ${completed ? "completed" : "incomplete"}-status-icon.svg`}
alt={`${completed ? "완료" : "미완료"} 문제 상태 아이콘`}
aria-label={`${completed ? "완료" : "미완료"} 문제`}
className={completed ? styles.completedIcon : styles.incompleteIcon}
/>
);
}
``` 이렇게 class부분까지 삼항 연산자로 옮기면 src가 null로 처리되고 정상적으로 렌더링 되지 않고 alt 값이 렌더링되는 현상이 발생해서 변수를 사용했는데 이유를 분석중에 있습니다.
There was a problem hiding this comment.
확인해보니 /뒤에 공백이 있어서 문제가 발생했던 것 같네요! 해결하고 push했습니다! 피드백 감사합니다!
Comment on lines
2
to
5
| display: flex; | ||
| z-index: var(--z-index-aside); | ||
| max-width: 203px; |
There was a problem hiding this comment.
position이 static일땐 z-index는 필요없다고 생각해요.
media query에 적용하면 어떨까요??
There was a problem hiding this comment.
그렇게 하는게 좋겠네요! 피드백 감사합니다!
There was a problem hiding this comment.
피드백 반영하고 push 했습니다 감사합니다! @Sunjae95
Open
|
메모 : 병합 후 접근성 테스트 활성화 해야함 |
SamTheKorean
had a problem deploying
to
chromatic
GitHub Actions
Failure
SamTheKorean
had a problem deploying
to
chromatic
GitHub Actions
Failure
SamTheKorean
temporarily deployed
to
chromatic
GitHub Actions
Inactive
SamTheKorean
temporarily deployed
to
chromatic
GitHub Actions
Inactive
SamTheKorean
temporarily deployed
to
chromatic
GitHub Actions
Inactive
SamTheKorean
temporarily deployed
to
chromatic
GitHub Actions
Inactive
Sunjae95
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
체크리스트
구현 사진
#모바일 & 테블릿
#데스크톱