Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack the jsroot sidebar. #37

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Hack the jsroot sidebar. #37

merged 1 commit into from
Dec 5, 2024

Conversation

ast0815
Copy link
Member

@ast0815 ast0815 commented Dec 3, 2024

This should fix #36. Bad hack with CSS attributes. The link to the documentation is JSROOT's own, so I just hid it.

@ast0815 ast0815 requested a review from jdkio December 3, 2024 17:24
@ast0815
Copy link
Member Author

ast0815 commented Dec 3, 2024

@jdkio You can check whether it now looks ok here: https://dune.github.io/dunendggd/

@ast0815
Copy link
Member Author

ast0815 commented Dec 4, 2024

If the page title is not "GitHub ref.: 37/merge", then another pull request has replaced it. In that case, let me know and I can rerun the action that uploads the files from this PR.

Copy link

@jdkio jdkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@ast0815 ast0815 merged commit 8b32a99 into master Dec 5, 2024
3 checks passed
@ast0815 ast0815 deleted the fix/jsroot-sidebar branch December 5, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix custom geometry loading button, and documentation link please
2 participants