Router advertisement & Router sollicitation #126
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjarry
requested changes
Jan 14, 2025
christophefontaine
force-pushed
the
router_advertisement
branch
from
957b425 to
78f1bb6
Compare
BGP unnumbered relies on RA message to discover the local routers. Broadcast the simplest router advertisement message on ipv6 enabled interfaces. Additional options (DNS, ... ) may be added in the future. Signed-off-by: Christophe Fontaine <[email protected]>
The returned nexthop for a multicast route lookup doesn't have a defined iface. Yet, this nexthop is valid, and we can rely on the iface defined by the parent node to select the output iface. Signed-off-by: Christophe Fontaine <[email protected]>
christophefontaine
force-pushed
the
router_advertisement
branch
2 times, most recently
from
7239bf0 to
a4f8458
Compare
rjarry
requested changes
Jan 16, 2025
christophefontaine
force-pushed
the
router_advertisement
branch
from
a4f8458 to
956c106
Compare
Upon reception of a router sollicit message, trigger the existing timer to send immediately a router advertismement packet. Signed-off-by: Christophe Fontaine <[email protected]>
Add configuration knobs for RA messages. Instead of a hardcoded perdiodic message, allow a per-interface configuration. Signed-off-by: Christophe Fontaine <[email protected]>
As the loopback interface is not ethernet based, well known multicast addresses were not registered: grout rejects the neighbor solicitation and router solication messages. Register to the well known multicast addresses even if there is no ethernet addresses configured on the interface. Signed-off-by: Christophe Fontaine <[email protected]>
christophefontaine
force-pushed
the
router_advertisement
branch
from
956c106 to
61f1307
Compare
| libsmartcols-dev libarchive-dev libibverbs-dev | ||
| ``` | ||
|
|
||
| ### Install optional dependencies |
There was a problem hiding this comment.
This deserves a separate commit for readability.
| @@ -32,5 +32,5 @@ ip netns exec $p1 ping6 -i0.01 -c3 fd00:ba4:2::2 | |||
| ip netns exec $p2 ping6 -i0.01 -c3 fd00:ba4:1::2 | |||
| ip netns exec $p1 ping6 -i0.01 -c3 fd00:ba4:1::1 | |||
| ip netns exec $p2 ping6 -i0.01 -c3 fd00:ba4:2::1 | |||
| ip netns exec $p1 traceroute6 -N1 fd00:ba4:2::2 | |||
There was a problem hiding this comment.
Idem, it can go to a separate commit especially as you did not describe the reason for this change in the current commitlog.
|
Some commitlog has a typo "perdiodic" (commenting here, as I don't see how to comment in gh webui for the specific commit..) |
rjarry
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
looks good to me after you rebase on the latest master and address @david-marchand's comments 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add router advertisement support, with basic configuration (lifetime, priority, interval, but no DNS, etc.).
Also answer to router sollicitation messages.
Depends on PR #112