-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI to check old db upgrade #2748
Conversation
Modification completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll wait for approval of someone else also but LGTM.
One last thing, can you describe in the commit message what things you did in the dump? So I assume you logged in as admin, created a user etc. would be good to clearly describe what was done so if needed we can extend this in the future.
Would be good to have as minimal:
- Created a team,
- Submitted as a team
- Submitted something wrong as a team
- Judged both submissions
- Resubmit something as an admin
- Send clarification as jury
- Send clarification as team
- Change a configuration option from default to something else
- Change an executable
- Do a rejudging of a single submission
If something wasn't done feel free to add it to the original issue so we can work on it in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments but besides that it looks good.
In this dump: 1. Created a user 2. Created a team 3. Uploaded problems with admin privileges 4. Created a new contest 5. Imported problems into the new contest 6. Submitted code with the team in all contests, with both AC and WA results 7. Rejudged previous submissions from the backend 8. Changed the code from the backend and uploaded it again 9. Sent a clarification from the team 10. Responded to the clarification from the admin 11. Changed the default configuration of lazy_eval
Changes made and explained the actions I performed in the dump. |
issue
#2577
Add version 7.3.3 data to check
dj_setup_database
upgrade.