Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to check old db upgrade #2748

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Update CI to check old db upgrade #2748

merged 1 commit into from
Oct 22, 2024

Conversation

as6325400
Copy link
Contributor

issue

#2577

Add version 7.3.3 data to check dj_setup_database upgrade.

@vmcj vmcj linked an issue Oct 20, 2024 that may be closed by this pull request
.github/workflows/database-upgrade.yml Outdated Show resolved Hide resolved
.github/workflows/database-upgrade.yml Outdated Show resolved Hide resolved
.github/workflows/database-upgrade.yml Outdated Show resolved Hide resolved
.github/workflows/database-upgrade.yml Show resolved Hide resolved
.github/workflows/database-upgrade.yml Outdated Show resolved Hide resolved
.github/jobs/webstandard.sh Outdated Show resolved Hide resolved
@as6325400
Copy link
Contributor Author

Modification completed.

Copy link
Member

@vmcj vmcj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait for approval of someone else also but LGTM.

One last thing, can you describe in the commit message what things you did in the dump? So I assume you logged in as admin, created a user etc. would be good to clearly describe what was done so if needed we can extend this in the future.

Would be good to have as minimal:

  • Created a team,
  • Submitted as a team
  • Submitted something wrong as a team
  • Judged both submissions
  • Resubmit something as an admin
  • Send clarification as jury
  • Send clarification as team
  • Change a configuration option from default to something else
  • Change an executable
  • Do a rejudging of a single submission

If something wasn't done feel free to add it to the original issue so we can work on it in the future.

@vmcj vmcj requested a review from a team October 22, 2024 07:10
Copy link
Member

@nickygerritsen nickygerritsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments but besides that it looks good.

.github/workflows/database-upgrade.yml Outdated Show resolved Hide resolved
.github/workflows/database-upgrade.yml Outdated Show resolved Hide resolved
.github/workflows/database-upgrade.yml Outdated Show resolved Hide resolved
.github/workflows/database-upgrade.yml Outdated Show resolved Hide resolved
.github/workflows/database-upgrade.yml Outdated Show resolved Hide resolved
In this dump:

1. Created a user
2. Created a team
3. Uploaded problems with admin privileges
4. Created a new contest
5. Imported problems into the new contest
6. Submitted code with the team in all contests, with both AC and WA results
7. Rejudged previous submissions from the backend
8. Changed the code from the backend and uploaded it again
9. Sent a clarification from the team
10. Responded to the clarification from the admin
11. Changed the default configuration of lazy_eval
@as6325400
Copy link
Contributor Author

Changes made and explained the actions I performed in the dump.

@vmcj vmcj added this pull request to the merge queue Oct 22, 2024
Merged via the queue into DOMjudge:main with commit 68438a6 Oct 22, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test database upgrades
3 participants