Check that last seen event ID exists while emitting the event feed #2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will throw an error, for example, when the database gets reloaded while there is a running process serving the event feed to a connected client. We encountered this problem at WF Astana.
nickygerritsen
approved these changes
Sep 18, 2024
Kevinjil
approved these changes
Sep 22, 2024
meisterT
approved these changes
Sep 22, 2024
| throw new HttpException(500, sprintf('Cannot find event %d in database anymore', $lastIdSent)); | ||
| } | ||
| // Remove the previously last sent event. We just fetched | ||
| // it to make sure it's there. |
There was a problem hiding this comment.
Suggested change
| // it to make sure it's there. | |
| // it to make sure it's still there. |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will throw an error, for example, when the database gets reloaded while there is a running process serving the event feed to a connected client. We encountered this problem at WF Astana.