-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow medal in contest setting categories when export results #2638
Conversation
When export the result, follow medal categories in contest setting. This will be consistent with the results generated by the award API. Signed-off-by: cubercsl <[email protected]>
Add every group in medal category
I think this config is only used with your contests, Can you extend @nickygerritsen his tests with a ranking of your contest (with teams in the same sortorder with some eligible for medals?), otherwise we always get this kind of PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we merge this I would like a specific test for such a scoreboard.
Signed-off-by: cubercsl <[email protected]>
The test data are based on Also, I moved the existing wf data to a subdirectory so that I could use different datasets in my tests. domjudge/webapp/tests/Unit/Service/AwardServiceTest.php Lines 89 to 113 in 6a99afc
|
It is a rare situation that medals cannot be distributed completely. It is almost impossible for medals to be awarded to a team didn't solve anything in a real contest. However, this is indeed the case in the test data. Signed-off-by: cubercsl <[email protected]>
10001 1 Gold Medal 4 36 20 Sample Group A | ||
10002 2 Gold Medal 2 5 3 | ||
10003 2 Gold Medal 2 5 3 | ||
10004 4 Highest Honors 1 12 12 Sample Group B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not really defined what order this file should be in, nor what should happen when some categories have no medals. It looks a bit weird like this, but I think this is the best we can do,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests were added so I'm fine with it.
When export the result, follow medal categories in contest setting. This will be consistent with the results generated by the award API.