Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link from card on contests overview page to single contest page #2624

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

vmcj
Copy link
Member

@vmcj vmcj commented Jul 25, 2024

The issue suggested using the header only but that felt a bit hard for people to find the link so the whole card is used now. The buttons in the card still work with their own links.

Fixes: #2462

<a href={{ path('jury_contest', {'contestId': contest.cid}) }}>

Is the only interesting piece, the rest is fixing indentation.

@nickygerritsen
Copy link
Member

Shouldn't we only link from the card header instead of the whole card?

@vmcj
Copy link
Member Author

vmcj commented Jul 26, 2024

Shouldn't we only link from the card header instead of the whole card?

See my first message, I found that hard to find and I don't see the problem with making the whole card clickable. Do we want a button to attract attention as alternative?

@nickygerritsen
Copy link
Member

I find it a bit strange that you can now click for example on the checkmark to open the contest, but that might just be me.

@vmcj
Copy link
Member Author

vmcj commented Jul 26, 2024

I find it a bit strange that you can now click for example on the checkmark to open the contest, but that might just be me.

Ok, do you want a button as alternative? I think it will be hard for people to find the feature if it only works with the header and I rather not have extra buttons. I do agree that clicking on the checkbox is a little strange. Let's see what the rest thinks.

@meisterT
Copy link
Member

meisterT commented Aug 3, 2024

What about adding a link to the header with <i class="fa-solid fa-pen"></i> as icon?

@vmcj
Copy link
Member Author

vmcj commented Aug 3, 2024

What about adding a link to the header with <i class="fa-solid fa-pen"></i> as icon?

I would consider that a button, but I'll change the PR with that change.

@vmcj
Copy link
Member Author

vmcj commented Sep 12, 2024

image

I associate pen with editing so went with another icon but anything from https://fontawesome.com/search?o=r&m=free should be fine.

@vmcj vmcj force-pushed the 2462_link_active_contests branch from 1115d33 to 6c3a0ab Compare September 12, 2024 15:13
@vmcj vmcj requested a review from meisterT September 12, 2024 15:13
The `folder` icon now links to the contest itself.
@vmcj vmcj force-pushed the 2462_link_active_contests branch from 9518f95 to c4a0e01 Compare September 13, 2024 11:22
@vmcj vmcj added this pull request to the merge queue Sep 13, 2024
Merged via the queue into DOMjudge:main with commit 6a70aa0 Sep 13, 2024
23 of 24 checks passed
@vmcj vmcj deleted the 2462_link_active_contests branch September 13, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link from card on contests overview page to single contest page
3 participants