Fix the line break in the tooltips of public statistics #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7b48be5.
Fix the line break in the tooltips of public statistics. Bootstrap5 uses data-bs-* instead of data-*, so `data-html` should be replaced by `data-bs-html`. After that, <br/> can be shown as a line break correctly. Also, all the tooltips should be initialized by js. This is already done in `domjudge.js`, but it's also outdated. See also: https://getbootstrap.com/docs/5.0/migration/#javascript Closes DOMjudge#2613 Signed-off-by: cubercsl <[email protected]>
This was removed accidentally in d74c94f. Signed-off-by: cubercsl <[email protected]>
nickygerritsen
approved these changes
Jul 23, 2024
meisterT
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the line break in the tooltips of public statistics.
Bootstrap5 uses
data-bs-*instead ofdata-*, sodata-htmlshould be replaced bydata-bs-html. After that,can be shown as a line break correctly.
Also, all the tooltips should be initialized by js. This is already done in
domjudge.js, but it's also outdated.See also: https://getbootstrap.com/docs/5.0/migration/#javascript
Closes #2613.
Also, popover initialization was accidentally removed in d74c94f, I have also revert this in this PR.
After fix, all tooltips in problemset statistics will be shown as below.