Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL main container #2620

Merged
merged 1 commit into from
Jul 27, 2024
Merged

MySQL main container #2620

merged 1 commit into from
Jul 27, 2024

Conversation

vmcj
Copy link
Member

@vmcj vmcj commented Jul 22, 2024

No description provided.

@vmcj vmcj force-pushed the mysql_main_container branch from 42992bd to 5670c85 Compare July 22, 2024 21:18
@vmcj vmcj marked this pull request as ready for review July 22, 2024 21:19
@vmcj vmcj force-pushed the mysql_main_container branch 2 times, most recently from f1df5c1 to ce27559 Compare July 23, 2024 06:34
@vmcj vmcj changed the title Mysql main container MySQL main container Jul 23, 2024
@eldering
Copy link
Member

Could you clarify the commit messages. The first "[remove]" is that commit intended to be dropped? Then please do so. The second, it's not clear which module is deprecated and how we're fixing this here: do we keep the old module, or not?

@vmcj
Fix start of MySQL container
c30dbd0 
The native password module used was deprecated with MySQL8 and doesn't work with MySQL9
anymore. It seems we don't need it anymore (I think we needed it because
the mariadb-utils did not have support for caching_sha2_password yet), but the alternative is to
keep using the MySQL8 container and not test for MySQL9.

Under the hood in the past we used to store the password as a hash in
the mysql.user table and now it's stored in another way
(https://dev.mysql.com/doc/refman/8.0/en/upgrading-from-previous-series.html#upgrade-caching-sha2-password)
which should also give better performance.

See: https://dba.stackexchange.com/a/209520
@vmcj vmcj force-pushed the mysql_main_container branch from ce27559 to c30dbd0 Compare July 23, 2024 14:37
@vmcj
Copy link
Member Author

vmcj commented Jul 23, 2024

Could you clarify the commit messages. The first "[remove]" is that commit intended to be dropped? Then please do so. The second, it's not clear which module is deprecated and how we're fixing this here: do we keep the old module, or not?

The commit [remove] needed to be dropped after approval as we only run MySQL tests on main not on PRs. So this was to show that now everything works again compared to main where this specific test was broken.

In the past we used native password which is now dropped in MySQL9, so the module/feature was already removed and the container failed to boot with that specific CLI flag. I've amended the commit message to have more background information. But in short defaults changed a while back and now we use the defaults again.

@vmcj vmcj requested a review from eldering July 23, 2024 14:38
@vmcj vmcj added this pull request to the merge queue Jul 27, 2024
Merged via the queue into DOMjudge:main with commit 9c2bb99 Jul 27, 2024
26 checks passed
@vmcj vmcj deleted the mysql_main_container branch July 27, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickygerritsen nickygerritsen nickygerritsen approved these changes

@eldering eldering Awaiting requested review from eldering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmcj @eldering @nickygerritsen