-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep patch release 8.3.1 #2619
Merged
Merged
Prep patch release 8.3.1 #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now track the autoload_runtime file and create it as the normal user and because it exists we don't recreate it in the install-domserver step as root (assuming it runs with `sudo`). It will still create it if it doesn't exist, because domserver is a dependency for install-domserver (and in that case `composer` would run as root again, so prompting the user to accept this risk). This also works for the inplace targets as those depend on `build` which runs the `domserver` part. (cherry picked from commit b404383)
This triggered an error and broke the webstandard test. (cherry picked from commit 6862840)
The authentication fails so needs to be rewritten with the new github action.
Signed-off-by: Dup4 <[email protected]>
It seems Python complains about this for some Python versions.
…roblem (cherry picked from commit 56104f6)
(cherry picked from commit eaf95fe)
…ntity (cherry picked from commit affacb4)
vmcj
force-pushed
the
prep_patch_release_8.3.1
branch
from
July 20, 2024 08:54
8f522ff
to
4f104e7
Compare
vmcj
force-pushed
the
prep_patch_release_8.3.1
branch
from
July 20, 2024 09:54
c569e75
to
8160e4b
Compare
nickygerritsen
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this to release the docker containers for 8.3 (or we need to fix the script there).
I forgot to use the
-x
flag for some of the commits but as those are in order it's not that hard to find the original commits if needed.