Use Gitlabci image in more GHA steps #2597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickygerritsen
approved these changes
Jun 17, 2024
The domjudge/gitlabci:2.1 is not actively pushed anymore.
Also upgraded to the latest versions for the actions and did some small cleanup to make the code more readable. The $USER is now set close to where we start the container as we use this in code and GHA didn't set this. Our container already has the packages so we don't need to run the apt steps anymore (for the speedup). Run CI with our container for speedup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll squash it after approval.
I think there should also be a way to only trigger this when the scripts like runguard etc. get changed because GitHub is aware of what are the differences between the PR and the target branch.