Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This unbreaks our teammanual generation #2205

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Conversation

vmcj
Copy link
Member

@vmcj vmcj commented Nov 4, 2023

Removing this seems to also remove the background color for the summary. We should investigate what was the goal of the LaTeX change and how we can reproduce it.

Also rst2pdf/rst2pdf#846 is now merged and released so we can remove a warning about the bool/str.

Closes: #2199

Removing this seems to also remove the background color for the summary.
We should investigate what was the goal of the LaTeX change and how we
can reproduce it.
@eldering eldering requested a review from thijskh November 4, 2023 16:03
@eldering
Copy link
Member

eldering commented Nov 4, 2023

This removes the background colour also of the code examples and a few other places. It clearly makes the layout a bit less nice, but if there's no other way to unbreak building the team manual without dirty hacks, then maybe this is worth it.
I've added @thijskh as reviewer, as I'm pretty sure he was the one who creates this layout.

@vmcj
Copy link
Member Author

vmcj commented Nov 4, 2023

I thought I had added the difference:
Original layout:
image

Now:
image

@vmcj
Copy link
Member Author

vmcj commented Nov 4, 2023

This removes the background colour also of the code examples and a few other places. It clearly makes the layout a bit less nice, but if there's no other way to unbreak building the team manual without dirty hacks, then maybe this is worth it. I've added @thijskh as reviewer, as I'm pretty sure he was the one who creates this layout.

Yes, he had created the layout. One fix I found which is a dirty hack is altering the generated .tex file. That would keep the color for the code examples.

@meisterT
Copy link
Member

While I liked the previous layout more, I do think this is acceptable to fix the issue.

@vmcj vmcj added this pull request to the merge queue Nov 26, 2023
@vmcj
Copy link
Member Author

vmcj commented Nov 26, 2023

@thijskh is already working on a proper fix, for now I'll merge this one so this works again.

Merged via the queue into DOMjudge:main with commit e3b5783 Nov 26, 2023
18 checks passed
@vmcj vmcj deleted the fix_sphinx_proposal branch November 26, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while running make dist
3 participants