Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chroot improvements #2198

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Chroot improvements #2198

merged 2 commits into from
Feb 12, 2024

Conversation

vmcj
Copy link
Member

@vmcj vmcj commented Oct 29, 2023

Closes #2196

@vmcj vmcj force-pushed the chroot_improvements branch from d5ed380 to 8f4570e Compare October 29, 2023 16:51
@vmcj vmcj requested a review from eldering October 29, 2023 16:51
eldering
eldering reviewed Oct 29, 2023
View reviewed changes
judge/chroot-settings.sh.in Outdated Show resolved Hide resolved
judge/chroot-settings.sh.in Outdated Show resolved Hide resolved
judge/chroot-settings.sh.in Outdated Show resolved Hide resolved
judge/Makefile Outdated Show resolved Hide resolved
@vmcj vmcj force-pushed the chroot_improvements branch from 8f4570e to e3ac769 Compare October 29, 2023 22:09
meisterT
meisterT reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@meisterT meisterT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to include some new documentation on how to use this.

judge/chroot-settings.sh.in Outdated Show resolved Hide resolved
@vmcj vmcj force-pushed the chroot_improvements branch from 823be9b to c702b7c Compare January 19, 2024 23:09
@vmcj
Explicit mention the difference between run_chroot and when judging.
e1c3b7c 
We add a mention of the current list for convenience but point the user
to the correct file in case the admin decides to mount more (or less).
@vmcj vmcj force-pushed the chroot_improvements branch from c702b7c to e1c3b7c Compare January 24, 2024 07:09
@vmcj vmcj requested a review from eldering January 24, 2024 07:10
@vmcj vmcj added this pull request to the merge queue Feb 12, 2024
Merged via the queue into DOMjudge:main with commit ebb27bb Feb 12, 2024
21 checks passed
@vmcj vmcj deleted the chroot_improvements branch February 12, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meisterT meisterT meisterT approved these changes

@eldering eldering Awaiting requested review from eldering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dj_run_chroot improvements
3 participants
@vmcj @meisterT @eldering