Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial rosetta virtis driver #520

Merged
merged 9 commits into from
Mar 6, 2024

Conversation

AustinSanders
Copy link
Contributor

@AustinSanders AustinSanders commented Feb 10, 2023

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@jlaura jlaura changed the base branch from master to main February 23, 2023 17:00
@AustinSanders
Copy link
Contributor Author

ATNR_P040302093352_00127.xc is ~13Mb, which is larger (I think?) than we normally aim for. This kernel cannot be sliced by CK slicer, and returns a message about it being an invalid spice type that may be supported in the future. Not sure how to handle this, so I included the whole file since it is not huge.

@AustinSanders AustinSanders marked this pull request as ready for review February 27, 2024 20:31
@AustinSanders AustinSanders requested a review from acpaquette March 5, 2024 17:59
Copy link
Collaborator

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs a changelog entry and this can be merged

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 136 lines in your changes are missing coverage. Please review.

Project coverage is 15.12%. Comparing base (c9656f6) to head (801afa8).
Report is 2 commits behind head on main.

Files Patch % Lines
ale/drivers/rosetta_drivers.py 0.00% 136 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
- Coverage   15.48%   15.12%   -0.36%     
==========================================
  Files          57       58       +1     
  Lines        6420     6570     +150     
==========================================
  Hits          994      994              
- Misses       5426     5576     +150     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AustinSanders AustinSanders merged commit 4ea98c6 into DOI-USGS:main Mar 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants