-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial rosetta virtis driver #520
Conversation
ATNR_P040302093352_00127.xc is ~13Mb, which is larger (I think?) than we normally aim for. This kernel cannot be sliced by CK slicer, and returns a message about it being an invalid spice type that may be supported in the future. Not sure how to handle this, so I included the whole file since it is not huge. |
10158e6
to
ed7c648
Compare
…rosetta_virtis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just needs a changelog entry and this can be merged
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
==========================================
- Coverage 15.48% 15.12% -0.36%
==========================================
Files 57 58 +1
Lines 6420 6570 +150
==========================================
Hits 994 994
- Misses 5426 5576 +150 ☔ View full report in Codecov by Sentry. |
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:
This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.