added missing HRSC properties #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessemapel
approved these changes
Aug 10, 2021
|
Was trying to compare to knoten notebooks but it seems like the HRSC notebook never ran as it is using a CTX image? Explains why this driver is in non-working order, probably never was finished. As I don't have much to compare against, and this makes an ISD possible, probably fine to merge. |
jessemapel
pushed a commit
that referenced
this pull request
May 30, 2022
* added missing HRSC properties * moved properties for instrument id to the top
jrcain-usgs
pushed a commit
to jrcain-usgs/ale
that referenced
this pull request
May 19, 2023
* added missing HRSC properties * moved properties for instrument id to the top
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HRSC driver for ISISLabel + NaifSpice was missing some required overrides, so this should patch those in.
fixes #424