Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new parameters OFFBODY and OFFBODYTRIM to cam2cam #5704

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

artmathgirl
Copy link
Contributor

Add new parameters OFFBODY and OFFBODYTRIM to cam2cam. Updated functional tests. Updated documentation.

Description

Enhance cam2cam to project all pixels in the focal plane - on and/or off the target body - to the output image. This has been extremely useful in detecting and tracking ejected particles from Bennu's surface.

Two program parameters were added - OFFBODY and OFFBODYTRIM.

Enhancement to cam2cam is necessary to support upcoming addition of the same new parameters (OFFBODY, OFFBODYTRIM) to noproj.

Related Issue

#3602

How Has This Been Validated?

Existing functional test passed.
New tests added to exercise the functionality of the new parameters, confirmed passing.

ctest -R Cam2Cam --output-on-failure
Test project /Users/ssutton/ISIS/GitCheckOuts/cam2camKeywords/ISIS3/build
Start 1354: DefaultCube.FunctionalTestCam2CamNoChange
1/2 Test #1354: DefaultCube.FunctionalTestCam2CamNoChange ... Passed 2.74 sec
Start 1355: DefaultCube.FunctionalTestCam2CamOffbody
2/2 Test #1355: DefaultCube.FunctionalTestCam2CamOffbody .... Passed 9.33 sec

100% tests passed, 0 tests failed out of 2

Total Test time (real) = 12.26 sec

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Copy link

github-actions bot commented Jan 9, 2025

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5704".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants