Add new parameters OFFBODY and OFFBODYTRIM to cam2cam #5704
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new parameters OFFBODY and OFFBODYTRIM to cam2cam. Updated functional tests. Updated documentation.
Description
Enhance cam2cam to project all pixels in the focal plane - on and/or off the target body - to the output image. This has been extremely useful in detecting and tracking ejected particles from Bennu's surface.
Two program parameters were added - OFFBODY and OFFBODYTRIM.
Enhancement to cam2cam is necessary to support upcoming addition of the same new parameters (OFFBODY, OFFBODYTRIM) to noproj.
Related Issue
#3602
How Has This Been Validated?
Existing functional test passed.
New tests added to exercise the functionality of the new parameters, confirmed passing.
ctest -R Cam2Cam --output-on-failure
Test project /Users/ssutton/ISIS/GitCheckOuts/cam2camKeywords/ISIS3/build
Start 1354: DefaultCube.FunctionalTestCam2CamNoChange
1/2 Test #1354: DefaultCube.FunctionalTestCam2CamNoChange ... Passed 2.74 sec
Start 1355: DefaultCube.FunctionalTestCam2CamOffbody
2/2 Test #1355: DefaultCube.FunctionalTestCam2CamOffbody .... Passed 9.33 sec
100% tests passed, 0 tests failed out of 2
Total Test time (real) = 12.26 sec
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: