-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Getter functions to CCPACSPositionings.h #1046
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1046 +/- ##
=======================================
Coverage 69.47% 69.48%
=======================================
Files 301 301
Lines 26887 26894 +7
=======================================
+ Hits 18681 18688 +7
Misses 8206 8206
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I'd like to add, I formatted some docstrings that were not part of this Issue, since we discussed improving tigls generated documentation by Doxygen. |
Thanks @merakulix! Have you tested if the newly added functions are available in Python? |
I built the python bindings on my machine, the newly added functions are available in Python. The output class type CCPACSPositioning is available now as well. |
Added Getter functions to CCPACSPositionings.h to make Positionings available via Python Bindings, which is currently not true for classes that store elements using the std::vector<std::unique_prt<TYPE>> and don't provide getter functions that return elements by index.
For further information see RISCSoftware/cpacs_tigl_gen#59
Description
New Functions:
CCPACSPositionings::GetPositioningCount()
CCPACSPositionings::GetPositioning(int index)
Implements Getter functions manually, as discussed in RISCSoftware/cpacs_tigl_gen#59, to fix missing functionality as described in #936.
Functions returning the type std::vector<std::unique_prt<TYPE>> will still not be available via Python Bindings.
How Has This Been Tested?
Added a test, checking missing functionality described in #936
Checklist: