-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: add option to choose host memory #75
Conversation
Cuda fix looks good imho |
Generally the changes look good. I don't think the phrasing of the UI is understandable, though, "CPU usage - check to enable" to me reads as it would execute segmentation on the GPU, I think it may confuse users. I'd change to something like "Use CPU memory" with a tooltip "Use host memory with a performance penalty. Enable if CUDA runs out of memory." so a user could more easily find it after seeing an error about memory usage. |
Thank you for the feedback! |
Hi @allemangD Thank you |
bd9bb98
to
2fb66de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! I'll merge now.
Hello @allemangD
I did some changes we discussed in the issue #66.
To resume them:
SlicerAutomatedDentalTools/AMASSS_CLI/AMASSS_CLI.py
Line 976 in 8602659
with this:
Output test:
On a machine equipped with an Intel Xeon Gold 6226R CPU running at 2.90GHz, with 62GB of memory and an NVIDIA RTX A6000 48GB, a CBCT scan with an approximate resolution of 0.3mm, covering the maxilla, mandible, skin, and cranial base, was segmented in 126.25 seconds.
Thank you!