-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1: validate required workflows usage across repositories #6
base: master
Are you sure you want to change the base?
#1: validate required workflows usage across repositories #6
Conversation
0a30b00
to
db017eb
Compare
8ad355d
to
3e43c5f
Compare
This PR adds a check for all non-forked DARMA-tasking repos to make sure they include the required workflows. The follow repos fail the check:
I will update the workflow to ignore any of these that we don't care about, but I want to make sure we're all on the same page before I do so. My suggestion is to add the missing check to both @nlslatt @lifflander @ppebay What do you think? |
I agree with your suggestion @cwschilly but will defer to @nlslatt and @lifflander for final decision. |
Yes, that sounds good to me. |
5159d66
to
39dabba
Compare
"DARMA-tasking.github.io", | ||
"find-unsigned-commits", | ||
"check-commit-format", | ||
"find-trailing-whitespace", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is trailing WS finder excluded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
find-unsigned-commits
, check-commit-format
, check-pr-fixes-issue
, and find-trailing-whitespace
are the actions that we're looking for in other DARMA-tasking repos. Since they don't run themselves (or any of the other actions), we can exclude them all from the check.
# Run on the first day of the month | ||
on: | ||
schedule: | ||
- cron: '0 0 1 * *' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused by the cron
values, could you put a comment to explain them for future reference? Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the comment; let me know if it is clear now.
dd8913a
to
f5acb76
Compare
78e70a9
to
fbecf8c
Compare
Fixes #1
Checks that every non-forked DARMA-tasking repository includes workflows in
.github/workflow
that use the following actions: