make host_groups & ioa_rule_groups required for prevention policies #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
host_groups&ioa_rule_groupsare currently optional, but changes made to make resource references (#49) and variable references (#51) exposed some state issues.The existing behavior is to remove any groups from a resource that does not specify a
host_groupsorioa_rule_groupsattribute. This keeps that behavior, but makes the action more explicit by requiring the attributes to be to sethost_groups = []&ioa_rule_groups = []while preventing a slew of state issues.