Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crowdstrike_prevention_policy_linux can't handle references in the host_groups #51

Closed
DiegoVazquezNanini opened this issue Nov 8, 2024 · 6 comments · Fixed by #52
Closed

Comments

@DiegoVazquezNanini
Copy link

We get a Value conversion error when passing a reference to host_groups.
After updating to 0.0.8 the error shows a different type.

issue 47
issue 50

383877879-242cded8-aa4c-44bb-9677-1eb47332e003

@ffalor
Copy link
Collaborator

ffalor commented Nov 14, 2024

Thanks for the report @DiegoVazquezNanini, I think I've identified the issue.

in #47 when you provide a reference to a resource the path is known, but the values are unknown so I added checks to fix that.

When you provide a reference the way you do in your example the whole path is unknown.

Working on a fix.

@ffalor ffalor reopened this Nov 14, 2024
@DiegoVazquezNanini
Copy link
Author

DiegoVazquezNanini commented Nov 15, 2024

Yes, I understand the root cause of the problem now, but this is a common thing in Terraform that I assumed was handled automatically, but it seems that is not the case.
My issue and 47 are the same problem.

@ffalor
Copy link
Collaborator

ffalor commented Nov 15, 2024

My comment was more for my records incase I come across this again in the future. Documenting how variables & resource references are different. The merging of pr #52, which fixed this error, automatically closed the issue. I reopened the issue while I work on publishing a release. I'll comment back when the version that contains your fix is released.

@ffalor
Copy link
Collaborator

ffalor commented Nov 15, 2024

v0.0.9 has been released & should fix your issue! Thanks for reporting it!

terraform {
  required_providers {
    crowdstrike = {
      source = "CrowdStrike/crowdstrike"
      version = "0.0.9"
    }
  }
}

@ffalor ffalor closed this as completed Nov 15, 2024
@DiegoVazquezNanini
Copy link
Author

Thank you @ffalor 🙇🏼
I will test it and get back to you. Seem working during my first local test.

@DiegoVazquezNanini
Copy link
Author

This solved the issue. Thank you 🙇🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants