Merge pull request #32 from CrowdStrike/type-checking

chore(ci): add type checking
CrowdStrike · May 26, 2021 · 45a7103 · 45a7103
2 parents b5cd671 + 0c0ad08
commit 45a7103
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -13,6 +13,19 @@ env:
   CI: true
 
 jobs:
+  type_checking:
+    if: "! contains(toJSON(github.event.commits.*.message), '[skip ci]')"
+    name: Check Types
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+      - uses: volta-cli/action@v1
+
+      - run: yarn install --frozen-lockfile
+      - run: yarn prepack
+
+
   tests:
     if: "! contains(toJSON(github.event.commits.*.message), '[skip ci]')"
     name: Base Tests
@@ -61,7 +74,7 @@ jobs:
     name: "Compatibility"
     timeout-minutes: 7
     runs-on: ubuntu-latest
-    needs: tests
+    needs: [ tests, type_checking ]
 
     strategy:
       fail-fast: true

diff --git a/addon/index.ts b/addon/index.ts
@@ -16,7 +16,7 @@ type TransitionWithPrivateAPIs = Transition & {
   };
 };
 
-export function withHashSupport(AppRouter: typeof EmberRouter) {
+export function withHashSupport(AppRouter: typeof EmberRouter): typeof AppRouter {
   return class RouterWithHashSupport extends AppRouter {
     constructor(...args: RouterArgs) {
       super(...args);

diff --git a/tests/dummy/app/app.js → tests/dummy/app/app.ts b/tests/dummy/app/app.js → tests/dummy/app/app.ts
diff --git a/tests/dummy/app/router.js → tests/dummy/app/router.ts b/tests/dummy/app/router.js → tests/dummy/app/router.ts
diff --git a/tests/test-helper.js → tests/test-helper.ts b/tests/test-helper.js → tests/test-helper.ts