storey: Containers section #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chipshort
approved these changes
Jul 19, 2024
| use cw_storey::containers::{Map, Item}; | ||
| use cw_storey::CwStorage; | ||
|
|
||
| let map: Map<String, Map<String, Item<u32>>> = Map::new(0); |
There was a problem hiding this comment.
Nice composition! One question I have: Why is the Item necessary here?
There was a problem hiding this comment.
I should probably make a callout about that.
Basically, Map is designed to take another container. It could maybe be redesigned to either take a container OR some serializable type, but it's tricky to do without specialization.
There was a problem hiding this comment.
Oh, I see. That's probably good to mention on the Map docs when those are written.
I think it's fine as is, as long as it's explained somewhere and shown like that in the examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.