Use cap() instead of len() to compute the spooling threshold #62

equals215 · 2025-01-20T10:02:35Z

len() provides the size of items in the buffer
cap() provides the size of the allocated underlying array holding the items

cap() is better suited than len() when used to preserve memory usage

…n the pool but just discard it

CorentinB

TestThresholdCrossing not passing, can you fix?

…f 2 and the buffer.cap() check when writing was making the test fail

…it when closing

feat: use cap() instead of len() to compute the spooling threshold

4661fc0

equals215 self-assigned this Jan 20, 2025

equals215 requested a review from CorentinB January 20, 2025 10:02

equals215 marked this pull request as draft January 20, 2025 10:06

equals215 added 2 commits January 20, 2025 11:15

feat: if the buffer is above the s.maxInMemorySize, don't return it i…

1881aa4

…n the pool but just discard it

fix: compute the len of the buffer AND the cap when deciding to spool

c92961f

equals215 marked this pull request as ready for review January 20, 2025 10:31

equals215 mentioned this pull request Jan 20, 2025

Cache RAM capacity (/proc/meminfo) readings and CAS when the cache is expired #63

Merged

CorentinB approved these changes Jan 20, 2025

View reviewed changes

equals215 added 2 commits January 20, 2025 13:46

fix: TestThresholdCrossing as a buffer grow is expressed in a power o…

2b40b87

…f 2 and the buffer.cap() check when writing was making the test fail

feat: also discard the buffer pointer if it's cap exceeded memory lim…

4aa7f24

…it when closing

CorentinB merged commit 64c28f2 into master Jan 20, 2025
1 check failed

equals215 deleted the spooled-use-cap branch January 20, 2025 12:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use cap() instead of len() to compute the spooling threshold #62

Use cap() instead of len() to compute the spooling threshold #62

equals215 commented Jan 20, 2025 •

edited

Loading

CorentinB left a comment •

edited

Loading

Use cap() instead of len() to compute the spooling threshold #62

Use cap() instead of len() to compute the spooling threshold #62

Conversation

equals215 commented Jan 20, 2025 • edited Loading

CorentinB left a comment • edited Loading

Choose a reason for hiding this comment

equals215 commented Jan 20, 2025 •

edited

Loading

CorentinB left a comment •

edited

Loading