Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8957 #9024

Merged
merged 10 commits into from
Jan 23, 2025
Merged

8957 #9024

merged 10 commits into from
Jan 23, 2025
+76 −50

Conversation

rolfyone
Copy link
Contributor

@rolfyone rolfyone commented Jan 22, 2025 •
edited
Loading

Rename GOSSIP_MAX_SIZE to MAX_PAYLOAD_SIZE

Waiting to confirm what we're passing to libp2p.

Fixes #8957

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@rolfyone
catch number format exception
7de89fb 
Signed-off-by: Paul Harris <[email protected]>
@rolfyone
spotless
ecc08af 
Signed-off-by: Paul Harris <[email protected]>
@rolfyone
libp2p gossip size setting
53a0e00 
Signed-off-by: Paul Harris <[email protected]>
@rolfyone rolfyone marked this pull request as ready for review January 23, 2025 02:51
@rolfyone rolfyone merged commit 2b37b47 into Consensys:master Jan 23, 2025
16 checks passed
@rolfyone rolfyone deleted the 8957 branch January 23, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucassaldanha lucassaldanha lucassaldanha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent GOSSIP_MAX_SIZE usage in GossipSub
2 participants
@rolfyone @lucassaldanha