Added block production restrictions for electra #9017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voluntary exits should not be included in a block if - they have a withdrawal pending (thats invalid) - they have a pending deposit (looking to make that invalid) The pending withdrawal was pointed out in devnet5, so this resolves that. The pending deposit is less cheap than i'd like ,but im fairly sure it'd potentially lead to some bad state data that we don't really want (eg. potentially depositing onto a withdrawn validator, so a withdrawn validator ending up with non 0 balance). Signed-off-by: Paul Harris <[email protected]>
…be on. Signed-off-by: Paul Harris <[email protected]>
…e a problem. Signed-off-by: Paul Harris <[email protected]>
|
i was convinced that deposit queue is not a problem so removed that check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
voluntary exits should not be included in a block if
The pending withdrawal was pointed out in devnet5, so this resolves that.
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog