Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in forward sync and rate limit constants #8982

Merged
merged 20 commits into from
Jan 15, 2025

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented Jan 10, 2025

PR Description

  • Changed DEFAULT_FORWARD_SYNC_BATCH_SIZE to 25 instead of 50 to cater for the time for validating blobs, state transition, etc
  • Removed -Xp2p-sync-rate-limit in favour of -Xp2p-sync-blocks-rate-limit and -Xp2p-sync-blob-sidecars-rate-limit
  • Removed --Xpeer-rate-limit in favour of --Xpeer-blocks-rate-limit and --Xpeer-blob-sidecars-rate-limit
  • Set DEFAULT_FORWARD_SYNC_MAX_BLOB_SIDECARS_PER_MINUTE to 2000 (outgoing rate limit). The previous 500 * maxBlobsPerBlock seems too large.
  • Set DEFAULT_PEER_BLOB_SIDECARS_RATE_LIMIT to 2000 (incoming rate limit). The previous 500 * maxBlobsPerBlock seems too large.
  • Increased DEFAULT_PEER_REQUEST_LIMIT to 100 from 50, because it hasn't been changed after Deneb. It makes sense to double to account for blobs requests when syncing.

2000 Blobs (TBD) is ~250 MB per minute per peer maximum allowed

Keep in mind that SyncSourceFactory uses the formula:

maxBlobSidecarsPerMinute - (batchSize * maxBlobsPerBlock) - 1)

So essentially 2000 turns into 1849 (pre-Electra) and 1774 (after Electra is scheduled)

Fixed Issue(s)

fixes #8871

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Sorry, something went wrong.

@StefanBratanov StefanBratanov changed the title Changes in forward sync constants Changes in forward/historical sync constants Jan 10, 2025
@StefanBratanov StefanBratanov changed the title Changes in forward/historical sync constants Changes in forward sync constants Jan 10, 2025
@StefanBratanov StefanBratanov changed the title Changes in forward sync constants Changes in forward sync and rate limit constants Jan 10, 2025
CHANGELOG.md Outdated Show resolved Hide resolved
@StefanBratanov StefanBratanov force-pushed the forward_sync_constants branch 2 times, most recently from 3ab199b to 40b7a50 Compare January 15, 2025 08:53
@StefanBratanov StefanBratanov enabled auto-merge (squash) January 15, 2025 12:46
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov merged commit c315305 into Consensys:master Jan 15, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit forward sync constants
3 participants