-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in forward sync and rate limit constants #8982
Merged
StefanBratanov
merged 20 commits into
Consensys:master
from
StefanBratanov:forward_sync_constants
Jan 15, 2025
Merged
Changes in forward sync and rate limit constants #8982
StefanBratanov
merged 20 commits into
Consensys:master
from
StefanBratanov:forward_sync_constants
Jan 15, 2025
+191
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanBratanov
changed the title
Changes in forward sync constants
Changes in forward/historical sync constants
Jan 10, 2025
StefanBratanov
changed the title
Changes in forward/historical sync constants
Changes in forward sync constants
Jan 10, 2025
StefanBratanov
force-pushed
the
forward_sync_constants
branch
from
January 10, 2025 14:07
b3d208e
to
d63e446
Compare
StefanBratanov
changed the title
Changes in forward sync constants
Changes in forward sync and rate limit constants
Jan 10, 2025
rolfyone
reviewed
Jan 12, 2025
StefanBratanov
force-pushed
the
forward_sync_constants
branch
2 times, most recently
from
January 15, 2025 08:53
3ab199b
to
40b7a50
Compare
tbenr
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
StefanBratanov
force-pushed
the
forward_sync_constants
branch
from
January 15, 2025 20:35
cf908e0
to
fc1a551
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
DEFAULT_FORWARD_SYNC_BATCH_SIZE
to 25 instead of 50 to cater for the time for validating blobs, state transition, etc-Xp2p-sync-rate-limit
in favour of-Xp2p-sync-blocks-rate-limit
and-Xp2p-sync-blob-sidecars-rate-limit
--Xpeer-rate-limit
in favour of--Xpeer-blocks-rate-limit
and--Xpeer-blob-sidecars-rate-limit
DEFAULT_FORWARD_SYNC_MAX_BLOB_SIDECARS_PER_MINUTE
to 2000 (outgoing rate limit). The previous500 * maxBlobsPerBlock
seems too large.DEFAULT_PEER_BLOB_SIDECARS_RATE_LIMIT
to 2000 (incoming rate limit). The previous500 * maxBlobsPerBlock
seems too large.DEFAULT_PEER_REQUEST_LIMIT
to 100 from 50, because it hasn't been changed after Deneb. It makes sense to double to account for blobs requests when syncing.2000 Blobs (TBD) is ~250 MB per minute per peer maximum allowed
Keep in mind that
SyncSourceFactory
uses the formula:So essentially
2000
turns into1849
(pre-Electra) and1774
(after Electra is scheduled)Fixed Issue(s)
fixes #8871
Documentation
doc-change-required
label to this PR if updates are required.Changelog