Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/xw 111/koophulpje #176

Merged
merged 11 commits into from
Nov 21, 2023
Merged

Feature/xw 111/koophulpje #176

merged 11 commits into from
Nov 21, 2023

Conversation

lencodes
Copy link
Contributor

@lencodes lencodes commented Nov 21, 2023

This pull request adds theme switcher logic.

  • Theme switcher top-bar component, which only shows when the theme switcher is activated in the config;
  • IF the theme switcher is enabled via domain name OR .env variables, it's forced ON, even if the JSON-config says it's off;
  • The theme, OIDN, Gateway-URL, Footer content and more is all updated when the switcher is used.

To test:

  • Disable GATSBY_ENV_VARS_SET in the .env.development (or keep enabled and enable GATSBY_SHOW_THEME_SWITCHER as well);
  • Uncomment // case "localhost.nl": // development purposes in useEnvironment() hook;
  • Uncomment // case "localhost": // development purposes in getConfig().

@lencodes lencodes requested a review from remko48 November 21, 2023 13:32
@lencodes lencodes marked this pull request as ready for review November 21, 2023 13:32
Copy link
Member

@remko48 remko48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@lencodes lencodes merged commit 1788347 into development Nov 21, 2023
3 checks passed
@lencodes lencodes deleted the feature/XW-111/koophulpje branch November 21, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants