-
Notifications
You must be signed in to change notification settings - Fork 36
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
7 changed files
with
141 additions
and
127 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| blank_issues_enabled: false | ||
| contact_links: | ||
| - name: Propose a New Feature or Ask a Question | ||
| url: https://github.com/communitytoolkit/maui.markup/discussions/new | ||
| about: Starting a discussion is the first step in creating a new feature proposal | ||
|
|
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| --- | ||
| name: Open a New Feature Proposal | ||
| about: For proposals that have been discussed in the Discussions tab and have been approved by a member of the core .NET MAUI Toolkit team | ||
| title: "[Proposal] " | ||
| labels: new, proposal | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| <!-- | ||
| Hello, and thanks for your interest in contributing to the .NET MAUI Toolkit! | ||
| If you haven't been invited by a team member to open an Proposal, please instead open a Discussion at https://github.com/communitytoolkit/maui.markup/discussions/new where we can discuss the pros/cons of the feature and its implementation. | ||
| New language feature proposals should fully fill out this template. This should include a complete detailed design, which describes the syntax of the feature, what that syntax means, and how it affects current parts of the spec. Please make sure to point out specific spec sections that need to be updated for this feature. | ||
| --> | ||
| # [FEATURE_NAME] | ||
|
|
||
| * [x] Proposed | ||
| * [ ] Prototype: Not Started | ||
| * [ ] Implementation: Not Started | ||
| * [ ] Documentation: Not Started | ||
| * [ ] Sample: Not Started | ||
|
|
||
| ## Link to Discussion | ||
|
|
||
| <!-- Please link to the completed/approved [Discussion](https://github.com/communitytoolkit/maui/discussions)--> | ||
|
|
||
| ## Summary | ||
| [summary]: #summary | ||
|
|
||
| <!-- One paragraph explanation of the feature. --> | ||
|
|
||
| ## Motivation | ||
| [motivation]: #motivation | ||
|
|
||
| <!-- Why are we doing this? Which use cases does it enable? What is the expected outcome? --> | ||
|
|
||
| ## Detailed Design | ||
| [design]: #detailed-design | ||
|
|
||
| <!-- This is the bulk of the proposal. Explain the design in enough detail for somebody familiar with .NET MAUI to understand, and for somebody familiar with the Community Toolkit to implement, and include examples of how the feature is used. Please include syntax and desired semantics for the change, including linking to the relevant parts of the existing .NET MAUI Toolkit spec to describe the changes necessary to implement this feature. An initial proposal does not need to cover all cases, but it should have enough detail to enable a community member to bring this proposal to design if they so choose. --> | ||
|
|
||
| ## Drawbacks | ||
| [drawbacks]: #drawbacks | ||
|
|
||
| <!-- Why should we *not* do this? --> | ||
|
|
||
| ## Alternatives | ||
| [alternatives]: #alternatives | ||
|
|
||
| <!-- What other designs have been considered? What is the impact of not doing this? --> | ||
|
|
||
| ## Unresolved Questions | ||
| [unresolved]: #unresolved-questions | ||
|
|
||
| <!-- What parts of the design are still undecided? --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,52 +1,20 @@ | ||
| <!-- | ||
| Hey there friend! First of all, thank you so much for this PR! | ||
| <!-- | ||
| Hello, and thanks for your interest in contributing to the .NET MAUI Toolkit! | ||
| Before doing a lot of work, please check if there's an open issue for this change and that it has been approved by one of our maintainers. | ||
| For Bug Fixes: | ||
| If you haven't yet opened an Issue that reports the bug in detail, provides a reproduction sample, and has been verified + reproduced by a member of the .NET MAUI Toolkit core team, please do that before submitting a Pull Request. Bug Fix Pull Requests without an associated Issue will be closed. | ||
| If not, please open an issue first so we can discuss upfront. | ||
| For New Feature Proposals: | ||
| If you haven't yet submitted a Proposal that has been Championed by a .NET MAUI core team member, please instead open a Discussion at https://github.com/communitytoolkit/maui/discussions/new where we can discuss the pros/cons of the feature and its implementation. | ||
| --> | ||
|
|
||
| ### Description of Change ### | ||
| ## Fixes | ||
| <!-- Please link to the Issue that this Pull Request resolves --> | ||
|
|
||
| <!-- Describe your changes here. --> | ||
| ## Description | ||
|
|
||
| ### Bugs Fixed ### | ||
| <!-- Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR. --> | ||
| <!-- Please copy/paste the Description/Summary from your Issue--> | ||
|
|
||
| - Fixes # | ||
| ## Detailed Solution | ||
|
|
||
| ### API Changes ### | ||
|
|
||
| <!-- List all API changes here (or just put None), example: | ||
| Added: | ||
| - `string Class.Property { get; set; }` | ||
| - `void Class.Method();` | ||
| Changed: | ||
| - `object Cell.OldPropertyName` => `object Cell.NewPropertyName` | ||
| If there is an entirely new API, then you can use a more verbose style: | ||
| ```csharp | ||
| public static class NewClass { | ||
| public static int SomeProperty { get; set; } | ||
| public static void SomeMethod(string value); | ||
| } | ||
| ``` --> | ||
|
|
||
| ### Behavioral Changes ### | ||
|
|
||
| <!-- Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase. --> | ||
|
|
||
| ### PR Checklist ### | ||
| <!-- Please check all the things you did here and double-check that you got it all, or state why you didn't do something --> | ||
| - [ ] Has a linked Issue, and the Issue has been `approved` | ||
| - [ ] Has tests (if omitted, state reason in description) | ||
| - [ ] Has samples (if omitted, state reason in description) | ||
| - [ ] Rebased on top of main at time of PR | ||
| - [ ] Changes adhere to coding standard | ||
| <!-- If at all possible, please update/add the documentation on the repo below. We would very much appreciate that. If you are unable to, please consider at least opening an issue on the repo below so we know that Docs still need to be adjusted/created. Thanks! <3 --> | ||
| - [ ] Updated Documentation | ||
| <!-- Please describe the solution in detail--> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters