fix: solve vulnerability with script metadata #816 #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Soare-Robert-Daniel
requested changes
Dec 18, 2023
|
@Soare-Robert-Daniel I think this could have been an NIT so as to not block instead of a change request. |
Soare-Robert-Daniel
approved these changes
Dec 18, 2023
|
@preda-bogdan, I was thinking about that. But I considered it pretty important since analyzing tools use the PHPDocs heavily. I see that PHPStan is not enabled in this project, which normally should not pass the check. I considered this NIT as an exception. |
|
@preda-bogdan Tested and the issue is fixed now, thank you 👍 |
|
🎉 This PR is included in version 2.10.27 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a vulnerability with using the custom fields to save data to the header/footer script boxes when the user does not have the capability to save
unfiltered_html.Screenshots
Post Preferences (pic. 1)
Post Preferences (pic. 2)
New custom fields name options (pic. 3)
How to test
ContributorroleContributorobfx-header-scriptsandobfx-footer-scriptsis not listed under the Add new custom field name.References: Codeinwp/themeisle#1612
Closes: #816