Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add new module with cricket Live Scores and news. #896 #932

Merged
merged 10 commits into from
May 16, 2024

Conversation

Arnav17Sharma
Copy link
Contributor

Description

Added ESPNCricinfo module and test file for live cricket scores and latest news from ESPNCricinfo website.

Resolves: #896

Checklist

Before submitting this pull request, kindly verify that the ensuing checkpoints have been reached.

  • Have you adhered to the repository's defined coding convention rules?
  • Have you updated the 'documentation.md' file with the method/function documentation?
  • Have you sent a message along with the result or response?
  • Have you used the try-catch technique?
  • Has the method/class been added to the documentation (md file)?

Screenshots

Here are some working examples of the module
image
image


I certify that I have carried out the relevant checks and provided the requisite screenshot for validation by submitting this pull request.
I appreciate your contribution.

Copy link
Member

@nikhil25803 nikhil25803 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arnav17Sharma I checked the code and it is working fine. Requeted few minor changes, address them and update the PR.

src/scrape_up/espncricinfo/espncricinfo.py Show resolved Hide resolved
@Arnav17Sharma
Copy link
Contributor Author

@nikhil25803
Added docstring in class. Please review.

@nikhil25803 nikhil25803 merged commit cc699bf into Clueless-Community:main May 16, 2024
@nikhil25803
Copy link
Member

Great work @Arnav17Sharma !!
Do not forget to

  • Share your contribution on socials and tag Clueless 🫂
  • Give this repository a star ✨
  • Follow Clueless Community on GitHub ✅

@nikhil25803 nikhil25803 added level3 gssoc GSSoC 2024 and removed under review labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC 2024 level3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Add new module with cricket Live Scores and news.
2 participants