Fix some warnings that come up with Xcode.

CloverHackyColor · Nov 9, 2023 · 2289e2e · 2289e2e
1 parent 652c25f
commit 2289e2e
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 8 deletions.
diff --git a/Protocols/AppleImageCodec/load_icns.c b/Protocols/AppleImageCodec/load_icns.c
@@ -103,7 +103,8 @@ VOID egCopyPlane(IN UINT8 *SrcPlanePtr, IN UINT8 *DestPlanePtr, IN UINTN PixelCo
 
   for (i = 0; i < PixelCount; i++) {
     *DestPlanePtr = *SrcPlanePtr;
-    DestPlanePtr += 4, SrcPlanePtr += 4;
+    DestPlanePtr += 4;
+    SrcPlanePtr += 4;
   }
 }
 

diff --git a/Protocols/AppleImageCodec/picopng.c b/Protocols/AppleImageCodec/picopng.c
@@ -149,7 +149,7 @@ void png_alloc_free(void *addr)
 	FreePool(addr);
 }
 
-void png_alloc_free_all()
+void png_alloc_free_all(void)
 {
 	while (png_alloc_tail) {
 		void *addr = png_alloc_tail->addr;
@@ -301,7 +301,7 @@ typedef struct
 	VECTOR_32 *tree2d;
 } HuffmanTree;
 
-HuffmanTree *HuffmanTree_new()
+HuffmanTree *HuffmanTree_new(void)
 {
 	HuffmanTree *tree = png_alloc_malloc(sizeof (HuffmanTree));
 	tree->tree2d = NULL;
@@ -1025,7 +1025,7 @@ INT32 PNG_convert(const PNG_INFO *info, VECTOR_8 *out, const UINT8 *in)
 	return 0;
 }
 
-PNG_INFO *PNG_info_new()
+PNG_INFO *PNG_info_new(void)
 {
 	PNG_INFO *info = png_alloc_malloc(sizeof (PNG_INFO));
 	UINT32 i;

diff --git a/Protocols/AppleKeyAggregator/AppleKeyAggregator.c b/Protocols/AppleKeyAggregator/AppleKeyAggregator.c
@@ -385,7 +385,7 @@ AggregatorEntryPoint (
   IN EFI_SYSTEM_TABLE  *SystemTable
   ) // start
 #else
-EFI_STATUS InstallAggregator()
+EFI_STATUS InstallAggregator(void)
 #endif
 {
   EFI_STATUS               Status;

diff --git a/Protocols/AppleKeyAggregator/AppleKeyAggregator.h b/Protocols/AppleKeyAggregator/AppleKeyAggregator.h
@@ -81,6 +81,6 @@ typedef struct {
   APPLE_KEY_STATE_PROTOCOL          AggregatorProtocol;  ///<0x50 size=8*3
 } APPLE_KEY_MAP_AGGREGATOR;  //size=0x68
 
-EFI_STATUS InstallAggregator();
+EFI_STATUS InstallAggregator(void);
 
 #endif
diff --git a/rEFIt_UEFI/cpp_lib/XmlLiteDictTypes.h b/rEFIt_UEFI/cpp_lib/XmlLiteDictTypes.h
@@ -180,7 +180,7 @@ XmlParserPosition valuePos = xmlLiteParser->getPosition();
     if ( xmlLiteParser->xmlParsingError ) {
       return false;
     }
-    int keyLen = keyTmp.value().length();
+    size_t keyLen = keyTmp.value().length();
     if ( keyLen > 0 )
     {
       if ( !( keyTmp.value()[0] == '#' && ignoreCommented ) && !(keyTmp.value()[keyLen-1] == '?') )

diff --git a/rEFIt_UEFI/refit/menu.cpp b/rEFIt_UEFI/refit/menu.cpp
@@ -1103,7 +1103,7 @@ void ApplyInputs(void)
   i++; //130
   if (InputItems[i].Valid) {
 	  INTN Minus = 0;
-	  gSettings.Quirks.OcBooterQuirks.TscSyncTimeout = StrDecimalToUintn(InputItems[i].SValue.data(Minus));
+	  gSettings.Quirks.OcBooterQuirks.TscSyncTimeout = (decltype(gSettings.Quirks.OcBooterQuirks.TscSyncTimeout))StrDecimalToUintn(InputItems[i].SValue.data(Minus));
 	  DBG("set TscSyncTimeout=%d\n", gSettings.Quirks.OcBooterQuirks.TscSyncTimeout);
   }
   //gSettings.Smbios.SFakeCPU