feature(args): Add clean mode #1470
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a clean mode to the application. When passing the argument --clean, the application hides some borders and adopts a cleaner interface with fewer borders.
felipe-heredia
force-pushed
the
feature/add-clean-mode
branch
from
4b54e79 to
ee88de7
Compare
|
Thanks for the PR! This has been a long standing issue, so I'm glad to see someone grab it. That said, I'm not totally a fan of adding a CLI flag specifically for it atm. This feels more like something I would set (IMO) as some style setting in a config/options screen. I might merge this for now but maybe change that specific part in the future. |
|
Thanks for your comment and for a possible merge. Yeah, that's a better idea, setting a config/option screen. This was my first contribution to Rust projects, so I've tried my best at the moment, but your idea is so much better option. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:
This PR introduces a new argument, clean, that adds a clean mode to the application.
Issue
This PR is directly related to #31 issue.
Closes: #31
Testing
This was tested passing
--cleanas an argument.If this is a code change, please also indicate which platforms were tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt)README.md, help menu, doc pages, etc.)