Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 카카오로그인 로컬&배포 분리 #62

Merged
merged 3 commits into from
Feb 18, 2024

Conversation

dainshon
Copy link
Collaborator

@dainshon dainshon commented Feb 18, 2024

요약 (Summary)

  • 로그인 로컬*배포 앤드포인트 분리

변경 사항 (Changes)

  • 1-1. 배포 앤드포인트: /kakao/login
  • 1-2. 로컬 앤드포인드: /kakao/login/local
    1. KAKAO_REDIRECT_URI_LOCAL 환경변수 추가
    1. getAccessToken에 앤드포인트에 따른 redirectUri 전달
    1. KakaoLogin 클래스 삭제 (사용되지 않고 있었음)

리뷰 요구사항

  • 각 앤드포인트가 잘 동작하는지 확인
  • 로컬, 배포 로그인이 잘 분리되었는지 확인

확인 방법 (선택)

기존 로그인과 같은 방식으로 테스트하면 됩니다.

Copy link
Contributor

@nonaninona nonaninona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 상 문제 없어보입니다
배포하고 테스트 해보죠~

@nonaninona nonaninona merged commit d5a9d74 into develop Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants