debug(laser af): only catch Exception, print exec_info, indicate failure for caller in autofocus method #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure for caller in autofocus method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds in more debugging for the case when auto focus fails, and gives an explicit printout in our acquisition loop if autofocus fails (and makes it clear that we just continue anyway!).
This just adds debugging, and shouldn't affect actual behavior.
Also a few logic cleanups to quiet the ide linter.
Tested by: I ran this on a system with autofocus. To get autofocus to fail, I had it scan onto a plate edge where it wouldn't find the 2 laser autofocus dots and made sure that the scan continued (but that we got printouts).