MovementUpdater: update FOV position and position_after_move signals and slots #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohamazing
changed the title
sohamazing
changed the title
sohamazing
changed the title
ianohara
reviewed
Jan 3, 2025
software/control/widgets.py
Outdated
| @@ -3729,13 +3729,13 @@ def update_well_coordinates(self, selected): | |||
| elif self.scanCoordinates.has_regions(): | |||
| self.scanCoordinates.clear_regions() | |||
|
|
|||
| def update_live_coordinates(self, x, y): | |||
There was a problem hiding this comment.
Can you change this PR to just contain the update_live_coordinates changes in this file? I think the others are unrelated or already in master.
the draw_current_fov changes look like they could be okay, but I think the and is just replicating previous logic - did something change there?
ianohara
reviewed
Jan 3, 2025
| self.stage.move_y_to(cached_pos.y_mm) | ||
| self.stage.move_z_to(cached_pos.z_mm) | ||
|
|
||
| if ENABLE_WELLPLATE_MULTIPOINT: |
There was a problem hiding this comment.
Is the duplication here on purpose?
There was a problem hiding this comment.
@sohamazing I think this is duplicated here. Is that on purpose?
sohamazing
force-pushed
the
fov-and-stage-bugs
branch
3 times, most recently
from
19b9bf4 to
589de99
Compare
…inates (position_after_move signal) fix move from well selector double click move to cached position on startup no longer hidden behind HOMING flags
sohamazing
force-pushed
the
fov-and-stage-bugs
branch
from
589de99 to
aed427f
Compare
ianohara
reviewed
Jan 20, 2025
| @@ -850,7 +849,7 @@ def makeConnections(self): | |||
| if ENABLE_FLEXIBLE_MULTIPOINT: | |||
| self.objectivesWidget.signal_objective_changed.connect(self.flexibleMultiPointWidget.update_fov_positions) | |||
| # TODO(imo): Fix position updates after removal of navigation controller | |||
| self.movement_updater.position_after_move.connect(self.navigationViewer.draw_fov_current_location) | |||
| self.movement_updater.position.connect(self.navigationViewer.draw_fov_current_position) | |||
There was a problem hiding this comment.
Is this definitely okay to do from a performance perspective? I think we had some issues with this causing way too many renders (but it might have just been for the scan grid preview case).
ianohara
requested changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed issues position update signals:
welplateMultiPointWIdget.update_live_coordinates(self, pos: squid.abc.Pos):
navigationViewer.draw_fov_current_position(self, pos: squid.abc.Pos)
move to cached position after boot